Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only drop migration_versions if it exists #130

Merged
merged 1 commit into from
Oct 23, 2024
Merged

Only drop migration_versions if it exists #130

merged 1 commit into from
Oct 23, 2024

Conversation

thijskh
Copy link
Member

@thijskh thijskh commented Oct 22, 2024

On new installs this table is not present, deal with this gracefully.

@thijskh
Only drop migration_versions if it exists
0496afd 
On new installs this old table is not present, deal with this gracefully.

Closes: #129
johanib
johanib approved these changes Oct 23, 2024
View reviewed changes
Copy link
Contributor

@johanib johanib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

I'm curious why there is no migration creating this table. Probably because doctrine needs this table to run migrations.
So it makes sense doctrine would not create the legacy table it on new installs.

@phavekes phavekes merged commit 476215f into main Oct 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johanib johanib johanib approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thijskh @johanib @phavekes