Build and publish test containers #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quartje
force-pushed
the
feature/build-and-publish-test-container
branch
3 times, most recently
from
c594c2f to
5abcedb
Compare
quartje
force-pushed
the
feature/build-and-publish-test-container
branch
from
5abcedb to
ea0709c
Compare
quartje
force-pushed
the
feature/build-and-publish-test-container
branch
from
ea0709c to
05e26fd
Compare
MKodde
force-pushed
the
feature/build-and-publish-test-container
branch
2 times, most recently
from
5e60000 to
9e6b8fa
Compare
MKodde
force-pushed
the
feature/build-and-publish-test-container
branch
2 times, most recently
from
824e60d to
8a950e7
Compare
quartje
force-pushed
the
feature/symfony6-upgrade
branch
3 times, most recently
from
571a185 to
5c3f26d
Compare
MKodde
force-pushed
the
feature/build-and-publish-test-container
branch
from
57a6a6d to
9978ce7
Compare
MKodde
force-pushed
the
feature/build-and-publish-test-container
branch
2 times, most recently
from
8e4ede9 to
7b7b0e3
Compare
MKodde
force-pushed
the
feature/build-and-publish-test-container
branch
2 times, most recently
from
1c24100 to
e40bd8e
Compare
MKodde
changed the title
MKodde
force-pushed
the
feature/build-and-publish-test-container
branch
from
e40bd8e to
ad35d7c
Compare
Points brought up by running the global behat tests
The regex in Stepup-Build to test the component_info has been extended to include * and /
The forms were not terminated resulting in invalid HTML.
MKodde
force-pushed
the
feature/build-and-publish-test-container
branch
from
4a39f16 to
ca0536a
Compare
And while at it. Remove the dev SURFnet repo mentions
MKodde
force-pushed
the
feature/build-and-publish-test-container
branch
from
6beb8b3 to
56aeed1
Compare
MKodde
approved these changes
Feb 22, 2024
Comment on lines
+10
to
13
| main_syslog: | ||
| type: stream | ||
| ident: stepup-selfservice | ||
| path: "php://stderr" | ||
| formatter: surfnet_stepup.monolog.json_formatter |
There was a problem hiding this comment.
@quartje previously we had a stepup-selfservice ident indentation in the log entries. This might not be very relevant anymore as the docker logs amend this to the logs. Leave it like this? Or is there a situation where we do want to grep on this ident value.
parijke
approved these changes
Feb 22, 2024
There was a problem hiding this comment.
Nul opmerkingen, alleen vraag:
Waarom is nu bij forms name nodig en voorheen niet? Is dat esthetisch of heeft het ook een functie?
Edit by Michiel: [For non Dutch readers], @parijke asked me
Why are forms now set with a name attribute.
This is purely for testing purposes. Maybe using a data-test attribute would have been more in line with the solution I chose later down the line. But still. I'm happy with this as-is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a Github action for building a test container, which will be used in behat tests