Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docker build test image workflow #421

Merged
merged 3 commits into from
Dec 19, 2024

Conversation

pablothedude
Copy link
Contributor

@pablothedude pablothedude commented Dec 10, 2024

Add missing GHA workflow to build test containers for PHP8.2

@pablothedude pablothedude force-pushed the feature/build-and-publish-test-container branch from d08612f to 7e30842 Compare December 10, 2024 14:00
Copy link
Contributor

@quartje quartje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That should do the trick. You might want to update all the actions to their latest versions so you're up2date. Other than that, good to go!

@pablothedude
Copy link
Contributor Author

That should do the trick. You might want to update all the actions to their latest versions so you're up2date. Other than that, good to go!

I've created a ticket in the backlog to update the actions themselves to do that all at once for all Stepup components. If there is some room I would also like to have a look at optimizing the test flow (for example multistage Dockerfiles) and in particular automate more. For example by always building the latest test release when a release is tagged and use nightly builds in devconf to contentiously validate the platform. But therefore I would like to have more input.

OpenConext/Stepup-Project#620

@pablothedude pablothedude requested a review from johanib December 18, 2024 09:26
@pablothedude pablothedude merged commit e74760b into main Dec 19, 2024
3 checks passed
@pablothedude pablothedude deleted the feature/build-and-publish-test-container branch December 19, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants