-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Manually expire cookies after a configured amount of time #321
Conversation
5baedce
to
0dd651e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for porting this to Stepup RA! See some feedback below
src/Surfnet/StepupRa/RaBundle/EventListener/AuthenticatedUserListener.php
Outdated
Show resolved
Hide resolved
declare(strict_types = 1); | ||
|
||
/** | ||
* Copyright 2016 SURFnet bv |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nitpick 2016 2024
{ | ||
return [ | ||
// The firewall, which makes the token available, listens at P8 | ||
// We must jump in after the firewall, forcing us to overwrite the translator locale. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See previous comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lookin' good. Please, write a small PR description before merging and tagging! I already set a more descriptive PR title, feel free to tweak that too.
Add listeners to replace the "old" handlers to manage cookie expiration. The values in
session_max_absolute_lifetime:
andsession_max_relative_lifetime:
will be used to calculate expiration