Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manually expire cookies after a configured amount of time #321

Merged
merged 2 commits into from
Jun 12, 2024

Conversation

parijke
Copy link
Contributor

@parijke parijke commented Jun 6, 2024

Add listeners to replace the "old" handlers to manage cookie expiration. The values in session_max_absolute_lifetime: and session_max_relative_lifetime: will be used to calculate expiration

@parijke parijke force-pushed the bugfix/cookie-deletion-and-expiring branch from 5baedce to 0dd651e Compare June 6, 2024 12:04
@parijke parijke requested a review from MKodde June 6, 2024 12:04
Copy link
Member

@MKodde MKodde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for porting this to Stepup RA! See some feedback below

bin/console Outdated Show resolved Hide resolved
config/services.yaml Show resolved Hide resolved
declare(strict_types = 1);

/**
* Copyright 2016 SURFnet bv
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick 2016 2024

{
return [
// The firewall, which makes the token available, listens at P8
// We must jump in after the firewall, forcing us to overwrite the translator locale.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See previous comment

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed comments

@MKodde MKodde changed the title Bugfix/cookie deletion and expiring Manually expire cookies after a configured amount of time Jun 12, 2024
Copy link
Member

@MKodde MKodde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lookin' good. Please, write a small PR description before merging and tagging! I already set a more descriptive PR title, feel free to tweak that too.

@parijke parijke merged commit c6ee51b into main Jun 12, 2024
2 checks passed
@parijke parijke deleted the bugfix/cookie-deletion-and-expiring branch June 12, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants