Process review feedback

OpenConext · Jun 12, 2024 · 3d28e82 · 3d28e82
1 parent 0dd651e
commit 3d28e82
Show file tree

Hide file tree

Showing 7 changed files with 8 additions and 12 deletions.
diff --git a/bin/console b/bin/console
@@ -1,7 +1,8 @@
 #!/usr/bin/env php
 <?php
 
-use src\Kernel;
+
+use Surfnet\StepupRa\Kernel;
 use Symfony\Bundle\FrameworkBundle\Console\Application;
 
 if (!is_file(dirname(__DIR__).'/vendor/autoload.php')) {

diff --git a/composer.json b/composer.json
@@ -8,7 +8,7 @@
             "Surfnet\\": "src\\Surfnet"
         },
         "classmap": [
-            "src/Kernel.php"
+            "src/Surfnet/StepupRa/Kernel.php"
         ]
     },
     "minimum-stability": "stable",

diff --git a/config/routes/controllers.yaml b/config/routes/controllers.yaml
@@ -3,5 +3,5 @@ controllers:
     type: attribute
 
 kernel:
-    resource: ../../src/Kernel.php
+    resource: ../../src/Surfnet/StepupRa/Kernel.php
     type: attribute
diff --git a/public/index.php b/public/index.php
@@ -18,8 +18,7 @@
  * limitations under the License.
  */
 
-
-use src\Kernel;
+use Surfnet\StepupRa\Kernel;
 
 require_once dirname(__DIR__).'/vendor/autoload_runtime.php';
 require_once dirname(__DIR__).'/config/bootstrap.php';

diff --git a/src/Kernel.php → src/Surfnet/StepupRa/Kernel.php b/src/Kernel.php → src/Surfnet/StepupRa/Kernel.php
@@ -18,7 +18,7 @@
  * limitations under the License.
  */
 
-namespace src;
+namespace Surfnet\StepupRa;
 
 use Symfony\Bundle\FrameworkBundle\Kernel\MicroKernelTrait;
 use Symfony\Component\HttpKernel\Kernel as BaseKernel;
@@ -30,6 +30,6 @@ class Kernel extends BaseKernel
     // see https://symfony.com/doc/current/reference/configuration/kernel.html#kernel-project-dir
     public function getProjectDir(): string
     {
-        return dirname(__DIR__);
+        return dirname(__DIR__, 3);
     }
 }
diff --git a/src/Surfnet/StepupRa/RaBundle/EventListener/AuthenticatedUserListener.php b/src/Surfnet/StepupRa/RaBundle/EventListener/AuthenticatedUserListener.php
@@ -3,7 +3,7 @@
 declare(strict_types = 1);
 
 /**
- * Copyright 2016 SURFnet bv
+ * Copyright 2024 SURFnet bv
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -42,8 +42,6 @@ public function __construct(
     public static function getSubscribedEvents(): array
     {
         return [
-            // The firewall, which makes the token available, listens at P8
-            // We must jump in after the firewall, forcing us to overwrite the translator locale.
             KernelEvents::REQUEST => ['updateLastInteractionMoment', 6],
         ];
     }

diff --git a/src/Surfnet/StepupRa/RaBundle/EventListener/ExplicitSessionTimeoutListener.php b/src/Surfnet/StepupRa/RaBundle/EventListener/ExplicitSessionTimeoutListener.php
@@ -49,8 +49,6 @@ public function __construct(
     public static function getSubscribedEvents(): array
     {
         return [
-            // The firewall, which makes the token available, listens at P8
-            // We must jump in after the firewall, forcing us to overwrite the translator locale.
             KernelEvents::REQUEST => ['checkSessionTimeout', 5],
         ];
     }