Make prove possession step optional #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pablothedude
force-pushed
the
feature/ra-optional-vetting
branch
2 times, most recently
from
b2f6231 to
57bf5c9
Compare
pablothedude
changed the base branch from
develop
to
feature/test-php-7-2-in-travis
MKodde
reviewed
Jul 27, 2020
src/Surfnet/Stepup/Helper/SecondFactorProvePossessionHelper.php
Outdated
Show resolved
Hide resolved
src/Surfnet/Stepup/Identity/Event/SecondFactorVettedPossessionSkippedEvent.php
Outdated
Show resolved
Hide resolved
src/Surfnet/StepupMiddleware/ApiBundle/Identity/Repository/AuditLogRepository.php
Outdated
Show resolved
Hide resolved
src/Surfnet/StepupMiddleware/ApiBundle/Controller/VerifiedSecondFactorController.php
Outdated
Show resolved
Hide resolved
pablothedude
changed the base branch from
feature/test-php-7-2-in-travis
to
develop
pablothedude
force-pushed
the
feature/ra-optional-vetting
branch
from
e7f8dd6 to
5f1d303
Compare
pablothedude
force-pushed
the
feature/ra-optional-vetting
branch
from
3cbd644 to
a96a5a7
Compare
MKodde
approved these changes
Jul 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Be aware that this is build on top of #307 so this needs to be merged back first!
This change will effectively make the the prove possession step optional. It's possible to configure the second factors which do not require that step.
https://www.pivotaltracker.com/story/show/172911922