Skip to content

Commit

Permalink
Minor changes after review
Browse files Browse the repository at this point in the history
  • Loading branch information
pablothedude committed Dec 17, 2024
1 parent 28d61a2 commit c118697
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 11 deletions.
8 changes: 0 additions & 8 deletions ci/qa/create-test-db

This file was deleted.

2 changes: 0 additions & 2 deletions ci/qa/phpunit
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,6 @@ set -e

cd $(dirname $0)/../../

#./ci/qa/create-test-db

# PHPUnit Bridge should always be used in Symfony applications. (https://symfony.com/doc/current/components/phpunit_bridge.html)
# This will create a phpunit executable in /bin/ instead of /vendor/bin/
./vendor/bin/phpunit --configuration=ci/qa/phpunit.xml --coverage-text --stop-on-error $1
Expand Down
4 changes: 3 additions & 1 deletion src/Surfnet/Stepup/Identity/Value/UnhashedSecret.php
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@

namespace Surfnet\Stepup\Identity\Value;

use SensitiveParameter;

/**
* Unhashed secret
*
Expand Down Expand Up @@ -51,7 +53,7 @@ public function hashSecret(): HashedSecret
return new HashedSecret($hashedSecret);
}

public function __construct(private readonly string $secret)
public function __construct(#[SensitiveParameter] private readonly string $secret)
{
}

Expand Down

0 comments on commit c118697

Please sign in to comment.