Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offload inline javascript to file #28

Merged
merged 3 commits into from
Dec 11, 2024

Conversation

tvdijen
Copy link
Contributor

@tvdijen tvdijen commented Oct 16, 2024

This doesn't solve everything, but it's a step in the right direction.
The language selector still relies on the onclick-event.

Legacy browsers and 'embedded' browsers like the one in Office do not always support event handlers
@thijskh thijskh requested a review from oharsta November 20, 2024 05:48
@oharsta oharsta merged commit 322fcb0 into OpenConext:main Dec 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants