Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not claim something has been sent to any administator #1329

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

thijskh
Copy link
Member

@thijskh thijskh commented Oct 8, 2024

There's no inherent guarantee in EB whatsoever that this error type will be sent to any administrator. Do not let people believe that it will be and wait for it to magically go away if they do nothing.

There's no inherent guarantee in EB  whatsoever that this error type
will be sent to any administrator. Do not let people believe that
it will be and wait for it to magically go away if they do nothing.
@thijskh thijskh requested a review from baszoetekouw October 8, 2024 11:44
Copy link
Member

@baszoetekouw baszoetekouw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely an improvement in the text, although I do think we should have more automated checks for these kinds of unexpected exceptions.

@baszoetekouw baszoetekouw merged commit 3c4bd63 into main Oct 23, 2024
2 checks passed
@thijskh thijskh deleted the errors/remove-sent-administrator-claim branch October 23, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants