Add feature flag to disable IdP-initiated authentication flow #1313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I suspect that 'under the hood' the acceptance test is failing because the new feature flag is missing from the test-configuration, but I have no clue where to look for that.. |
MKodde
force-pushed
the
feature/configurable-idp-initiated
branch
from
a890b21 to
d19a56a
Compare
1. The TestFeatureConfiguration missed the default setting. Causing some of the behat tests to fail (the ones running the check in the controller) 2. I added a dedicated test that tests if the flag can disable the unsolicited sso flow See: OpenConext#1312
MKodde
force-pushed
the
feature/configurable-idp-initiated
branch
from
d19a56a to
2de1a17
Compare
|
Sweet 'n simple solution @tvdijen 👌 To fix the tests, you missed the addition of the feature flag to the test feature flag service. While fixing your tests, I took the opportunity to also add a Behat test. That required me to inject the FunctionalTesting feature flag service on the IdP controller in test. If you check my code, I'll approve yours. |
MKodde
approved these changes
Aug 27, 2024
thijskh
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1312