Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Request Access bugfixes #1271

Merged
merged 3 commits into from
Sep 28, 2023
Merged

Request Access bugfixes #1271

merged 3 commits into from
Sep 28, 2023

Conversation

thijskh
Copy link
Member

@thijskh thijskh commented Sep 27, 2023

  • The 'motivation' field seems to be actually required, since submitting the form without it filled fails (with no message). Simplest solution is to also make it required in the front end so it's clear to the user they need to fill this in. It also makes sense to require a motivation with the report.
  • Mails fail to send because the From is set to the user's emailadress, which we may not be allowed to send mail as at all. Change this to the To address which we own and can send mail as.

@thijskh
Request access: make form indicate that motivation is required
09fd043 
Currently upon submitting, the form is not accepted when motivation
is left empty, however there's no form feedback beforehand or in
fact anytime, the form just doesn't submit.

We fix this the easy way by adding the required '*' indicator and
using browser form validation to require the form to be filled in.
@thijskh
Request access: set from to to address.
bad48c6 
In modern times we cannot expect to be able to send email "From" the user's
entered email address from our systems. Use the To address instead which we
have available and belongs to us.
@thijskh thijskh requested a review from MKodde September 27, 2023 20:08
MKodde
MKodde approved these changes Sep 28, 2023
View reviewed changes
Copy link
Member

@MKodde MKodde left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good.

  1. The validation message is now only a browser message right? Thats probably different from the messages that the other fields get? But I should start my VM to verify that. I'm totaly fine with that as long as it meets your expectations.
  2. Good point on setting the FROM header to use the same address we send to. That increases chance of delivery. It however is slightly unexpected from a casual point of view. So maybe add a comment that explains why we use the same address for both situations?

@thijskh
Copy link
Member Author

thijskh commented Sep 28, 2023

  1. This is indeed the case. Previously it just failed silently so this is an improvement over the status quo. As indicated elsewhere I don't see the business case for this feature to spend more time for just a validation message. If someone thinks this message should be presented differently, they can do that.
  2. I will add a comment. A more structural way could be to introduce a new "mail sender address" setting in EB and use that everywhere, but again, seems to much work for the amount of gain.

@thijskh thijskh merged commit fb92bbe into master Sep 28, 2023
2 checks passed
@thijskh thijskh deleted the bugfix/request-access-motivation-required branch September 28, 2023 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MKodde MKodde MKodde approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thijskh @MKodde