Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/eb to docker #458

Merged
merged 8 commits into from
Nov 27, 2024
Merged

Feature/eb to docker #458

merged 8 commits into from
Nov 27, 2024

Conversation

quartje
Copy link
Contributor

@quartje quartje commented Nov 20, 2024

This PR transforms the VM based installation of Docker to a Docker based installation

@quartje quartje requested a review from thijskh November 20, 2024 07:27
roles/engineblock/tasks/main.yml.old Outdated Show resolved Hide resolved
roles/engineblock/templates/parameters.yml.j2 Outdated Show resolved Hide resolved
Copy link
Member

@thijskh thijskh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The role now no longer executes migrations, so there needs to be some kind of other solution for migrating if this is merged. Otherwise looks good 👍

@quartje quartje force-pushed the feature/eb_to_docker branch 2 times, most recently from bcc1797 to 69e77f2 Compare November 27, 2024 14:08
@quartje quartje force-pushed the feature/eb_to_docker branch from 69e77f2 to 10354e7 Compare November 27, 2024 14:09
@quartje
Copy link
Contributor Author

quartje commented Nov 27, 2024

The role now no longer executes migrations, so there needs to be some kind of other solution for migrating if this is merged. Otherwise looks good 👍

As discussed, a generic role will be made to do migrations, reusable for all symfony apps

@quartje quartje merged commit a2f05f3 into main Nov 27, 2024
2 of 4 checks passed
@quartje quartje deleted the feature/eb_to_docker branch November 27, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants