Feature/no more vm #456
Merged
Feature/no more vm #456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no more Vagrant support, and all applications run from Docker. The docs have been updated to reflect this
- Remove Vagrant VM stuff - Remove remove secrets_file location and use a default value - Remove the user argument for the provision script - enviromment_dir is no longer needed. The ansible magic var inventory_dir is reintroduced. You need to add localhost to the inventory for this to work
quartje
force-pushed
the
feature/no_more_vm
branch
from
17ac40c to
c19587f
Compare
baszoetekouw
requested changes
Dec 13, 2024
There was a problem hiding this comment.
Lijkt me prima @quartje
Kun jij nog even de conflicts fixen, dan merge ik hem
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This repo has changed a lot in the last year, since we went from a CentOS7 VM based install to a Docker based approach on Debian 12. A lot of the documentation, VM setup and tests have become obsolete since then.
This PR also simplifies the provision script. The only argument needed is the environment you want to use.
Two elements are currently missing, which were present before:
The wiki should be updated as well after merging this PR.