Bugfix for Nullpointer URL validation

OpenConext · Oct 22, 2023 · 2beb4bb · 2beb4bb
1 parent 4ca0cf2
commit 2beb4bb
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/server/src/main/java/access/api/RoleController.java b/server/src/main/java/access/api/RoleController.java
@@ -24,6 +24,7 @@
 import org.springframework.http.MediaType;
 import org.springframework.http.ResponseEntity;
 import org.springframework.transaction.annotation.Transactional;
+import org.springframework.util.StringUtils;
 import org.springframework.validation.annotation.Validated;
 import org.springframework.web.bind.annotation.*;
 
@@ -137,7 +138,7 @@ public ResponseEntity<Void> deleteRole(@PathVariable("id") Long id, @Parameter(h
     }
 
     private ResponseEntity<Role> saveOrUpdate(Role role, User user) {
-        if (!urlFormatValidator.isValid(role.getLandingPage())) {
+        if (StringUtils.hasText(role.getLandingPage()) && !urlFormatValidator.isValid(role.getLandingPage())) {
             throw new InvalidInputException();
         }
         Map<String, Object> provider = manage.providerById(role.getManageType(), role.getManageId());