Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use QDesktopServices on Linux too with Qt 6, which fixes opening URLs #527

Merged
merged 1 commit into from
Nov 17, 2024

Conversation

matterhorn103
Copy link
Contributor

Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or

(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or

(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.

(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.

@matterhorn103
Copy link
Contributor Author

matterhorn103 commented Nov 14, 2024

The links to the website, forums, GitHub bug reports etc. are broken in Qt6 builds currently. This fixes it.

I think the native builds are broken because the use of a single string with QProcess::execute() is deprecated. In theory it could be fixed just by breaking up the arguments into a list of strings.

However, QDesktopServices::openUrl() goes via the appropriate XDG portal on Linux, which means that it works even from a sandbox, so this works for the Flatpak (verified) and presumably will for the AppImage too.

(In general we should use the portals on Linux wherever possible, which basically means using QDesktopServices::openUrl() and the normal QFileDialog).

I suspect that the original issue that led to Linux being handled differently was due to the user not having xdg-desktop-portal set up and running correctly. But like I say, I can't work out when QDesktopServices started making use of the XDG portal, so for safety I kept the behaviour on Qt5 the same.

@ghutchis ghutchis merged commit 8d4adc7 into OpenChemistry:master Nov 17, 2024
27 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants