-
Notifications
You must be signed in to change notification settings - Fork 959
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[backend] add missing backend feature to exclusion list (#8941) #9177
base: release/6.5.0
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/6.5.0 #9177 +/- ##
=================================================
+ Coverage 64.93% 64.96% +0.02%
=================================================
Files 626 626
Lines 59722 59771 +49
Branches 6620 6635 +15
=================================================
+ Hits 38783 38829 +46
- Misses 20939 20942 +3 ☔ View full report in Codecov by Sentry. |
5ede59c
to
6840f87
Compare
type ExclusionListCacheStatus { | ||
refreshAskDate: String! | ||
cacheDate: String! | ||
allNodeCacheUpdated: Boolean! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why String for the dates and not DateTime ? and also all these values can be null I guess ?
Also the naming is not ideal, here are my suggestions if you like them better:
cacheDate: DateTime
isCacheRebuildInProgress: Boolean!
So that the frontend can use this isCacheRebuildInProgress to display a progress status if it's true, and if it's false, then cache is up to date. Do we need more info ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or maybe we would like the refreshAskDate for debug purposes ?
Tested locally:
|
Proposed changes
Related issues
Checklist
Further comments