Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend/backend] Add new markings to max_shareable_markings of groups with auto_new_marking (#7944) #9076

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

Archidoit
Copy link
Member

Proposed changes

  • New marking should be automatically added to max_shareable_markings of the groups with auto_new_marking = true
  • UI fixes for max shareable markings in Group overview and group edition form
  • Add tests for group with auto_new_marking = true

Related issues

#7944

@Archidoit Archidoit added the filigran team use to identify PR from the Filigran team label Nov 19, 2024
@Archidoit Archidoit self-assigned this Nov 19, 2024
@Archidoit Archidoit marked this pull request as draft November 19, 2024 08:35
@Archidoit Archidoit changed the title [frontend/backend] New markings added to max_shareable_markings of groups with auto_new_marking (#7944) [frontend/backend] Add new markings to max_shareable_markings of groups with auto_new_marking (#7944) Nov 19, 2024
@Archidoit Archidoit marked this pull request as ready for review November 19, 2024 13:28
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.72%. Comparing base (d3a85de) to head (fb67643).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9076      +/-   ##
==========================================
+ Coverage   64.68%   64.72%   +0.03%     
==========================================
  Files         620      620              
  Lines       59208    59231      +23     
  Branches     6520     6532      +12     
==========================================
+ Hits        38301    38335      +34     
+ Misses      20907    20896      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@lndrtrbn lndrtrbn self-requested a review November 26, 2024 09:22
Copy link
Member

@lndrtrbn lndrtrbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I create a new marking with lower order than a one a group already has on max sharing, it still replaces the existing one

@Archidoit
Copy link
Member Author

When I create a new marking with lower order than a one a group already has on max sharing, it still replaces the existing one

fixed :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option "auto new marking" in groups not working on max_shareable_markings, could make exports fail
2 participants