[MacOS] Add timeout to connect #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdewald
reviewed
Sep 6, 2023
kdewald
reviewed
Sep 6, 2023
|
@Andrey1994 this will probably also fix the issues that you saw. |
|
Yes, I saw this PR, thanks! At least should not hang in deadlock, and maybe will solve the issue completly |
|
I'm quite mad that I missed that detail in the documentation. Given that they have callbacks for failed connections, it seems dumb that the user has to manually implement their own timeout logic. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corebluetooth docs:
Attempts to connect to a peripheral don't time out. SimpleBLE should expose a connectWithTimeout method to handle this flow gracefully for the consumer.