Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SAFE representation #482

Merged
merged 13 commits into from
Nov 7, 2023
Merged

Add SAFE representation #482

merged 13 commits into from
Nov 7, 2023

Conversation

MicPie
Copy link
Contributor

@MicPie MicPie commented Nov 6, 2023

No description provided.

@MicPie MicPie requested a review from kjappelbaum November 6, 2023 11:58
@kjappelbaum kjappelbaum marked this pull request as ready for review November 6, 2023 20:39
@kjappelbaum
Copy link
Collaborator

To me it looks ok now ;)

@kjappelbaum
Copy link
Collaborator

should update the safe dependency as soon as datamol-io/safe#16 is merged

pyproject.toml Outdated Show resolved Hide resolved
Copy link
Collaborator

@kjappelbaum kjappelbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kjappelbaum kjappelbaum merged commit 24d0c58 into main Nov 7, 2023
0 of 2 checks passed
@kjappelbaum kjappelbaum deleted the add_safe_representation branch November 7, 2023 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants