Remove extra system header include files #291
Conversation
Many of the system specific irq.h files are empty, and those that are not are only used by the internal IRQ handling functions. Remove the empty ones and do not expose the contents of the internal ones outside of the compilation unit that uses them. Signed-off-by: Andrew Davis <[email protected]>
Most of the system specific log.h files are empty, and those that are not are only used by the internal log handling functions. Remove the empty ones and do not expose the contents of the internal ones outside of the compilation unit that uses them. Signed-off-by: Andrew Davis <[email protected]>
|
LGTM. |
| @@ -93,8 +93,6 @@ void metal_irq_enable(unsigned int vector); | |||
| */ | |||
| void metal_irq_disable(unsigned int vector); | |||
|
|
|||
| #include <metal/system/@PROJECT_SYSTEM@/irq.h> | |||
|
|
|||
There was a problem hiding this comment.
the only use case we need it is to include /lib/system/linux/irq.h
@tnmysh , @edmooring does AMD need the metal_linux_irq_register_dev() as external API?
There was a problem hiding this comment.
I am not sure, but I prefer to keep headers for now.
Can take a look after this release.
There was a problem hiding this comment.
I am not sure, but I prefer to keep headers for now. Can take a look after this release.
Probably late to address for this release without some risks...?
@tnmysh could you add it in your review list that we merge it ( or not) just after the release?
There was a problem hiding this comment.
I agree, this can be reviewed and merged after the release.
| @@ -111,6 +111,4 @@ extern void metal_default_log_handler(enum metal_log_level level, | |||
| } | |||
| #endif | |||
|
|
|||
| #include <metal/system/@PROJECT_SYSTEM@/log.h> | |||
There was a problem hiding this comment.
metal_zephyr_log_handler not used in zephyr so LGTM
|
This pull request has been marked as a stale pull request because it has been open (more than) 45 days with no activity. |
No description provided.