Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Redout: Enhanced Edition #181

Closed
wants to merge 7 commits into from

Conversation

Arias800
Copy link
Contributor

@Arias800 Arias800 commented Dec 18, 2024


def main() -> None:
# Requires vcrun2019 to launch
util.protontricks('vcrun2019')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you happen to only have this title from Epic? According to Steam, it's Deck Verified and the recent ProtonDB report shows the title works out of the box so there shouldn't be a need for vcrun2019.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

@Arias800 Arias800 Dec 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I only have this title on Epic.
On Steamdb, I saw the last update of the game was in 2022, and there was a report 1 year ago on Protondb that said vcrun2019. Maybe it was someone using the Epic and it wasn't mentioned.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On Steamdb, I saw the last update of the game was in 2022

While the game hasn't been updated, Proton / Wine has. So that's not really a good indicator.

Maybe it was someone using the Epic and it wasn't mentioned.

Possible. Let's assume it works on Steam, as evidence implies.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Furthermore, inspecting the depot for that title, one can see vcrun2019 as part of the game’s redistributables.

https://steamdb.info/app/517710/depots/

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert the Steam fix and keep it local to the EGS version.

Arias800 and others added 6 commits December 19, 2024 17:51
Game needs xna40 to play intro and in game videos as well as fix the music
* Add fix for Bus Simulator 21 Next Stop

* Remove steam file
@Arias800
Copy link
Contributor Author

I clearly did something wrong with git.
I prefer to do a clean pull requets.

@Root-Core
Copy link
Contributor

I clearly did something wrong with git. I prefer to do a clean pull requets.

Rebase and force-push to your branch.
This is the silver bullet with PRs. 👍🏻

@Arias800
Copy link
Contributor Author

Yes, but I don't want to risk making the whole thing even less readable.
I don't have enough experience with Github cli.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants