Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: build xorg-macros before xrandr #117

Merged
merged 2 commits into from
Aug 31, 2024

Conversation

R1kaB3rN
Copy link
Member

@R1kaB3rN R1kaB3rN commented Aug 31, 2024

Fixes potential build errors for the xrandr target by first installing xorg-macros. Attempting to build xrandr without this build dependency may result in the following error:

Package xorg-macros was not found in the pkg-config search path.
Perhaps you should add the directory containing `xorg-macros.pc'
to the PKG_CONFIG_PATH environment variable
No package 'xorg-macros' found
checking whether make supports nested variables... (cached) yes
checking for floor in -lm... yes
checking for XRANDR... yes
checking that generated files are newer than configure... done
configure: creating ./config.status
config.status: creating Makefile
config.status: creating man/Makefile
config.status: creating config.h
config.status: executing depfiles commands
make[1]: Entering directory '/workspace/subprojects/x11-xserver-utils/xrandr'
CDPATH="${ZSH_VERSION+.}:" && cd . && /bin/bash '/workspace/subprojects/x11-xserver-utils/xrandr/missing' aclocal-1.16 
configure.ac:34: error: must install xorg-macros 1.8 or later before running autoconf/autogen
configure.ac:34: the top level
autom4te: /usr/bin/m4 failed with exit status: 1
aclocal-1.16: error: autom4te failed with exit status: 1
make[1]: Leaving directory '/workspace/subprojects/x11-xserver-utils/xrandr'
make[1]: *** [Makefile:445: aclocal.m4] Error 1
make: *** [Makefile:36: builddir/.build-xrandr-dist] Error 2

which may negatively impact the build process for GE-Proton.

@R1kaB3rN R1kaB3rN marked this pull request as ready for review August 31, 2024 18:45
@GloriousEggroll GloriousEggroll merged commit 286404f into Open-Wine-Components:master Aug 31, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants