Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

star citizen gamefixes #116

Merged
merged 1 commit into from
Aug 31, 2024

Conversation

mactan-sc
Copy link
Contributor

contingent upon winetricks being of a recent enough version to contain powershell verbs
Winetricks/winetricks#2256
Winetricks/winetricks#2211

@R1kaB3rN
Copy link
Member

Alternatively, we can just bisect the relevant patches and create our own custom powershell verb for now, which avoids having to bump winetricks to the latest git.

@R1kaB3rN
Copy link
Member

Also, do you mind providing more context for this change on Star Citizen?

@ProjectSynchro
Copy link
Contributor

ProjectSynchro commented Aug 31, 2024

Figured I'd chime in:

In terms of why this change is needed, here's some context: lutris/lutris#5577
Essentially, with the forced update to the new 2.0.x launcher, powershell becomes required for basic launcher functionality.

Game data verification, game folder creation and some kind of dependency check all require powershell now (as a dependency).

Currently, The folders that would be created from the launcher itself are made via the protonfix.

In the 1.6.10 launcher you can get around the powershell requirement by disabling it via a wine dll override and creating the folders yourself.

Now in the new 2.0.x launcher when verifying the game files (which happens during the process of installing a patch) the launcher falls over and fails due to the fact it checks the status of the game folders.

Unfortunately (or fortunately) it looks like PowerShell is being used to call CMD to run a utility batch file. On Windows you can use that as a method for elevating a process which CIG does, in Wine we get a stub instead.

Some paths forward:

  1. Pull in the verbs I have in the upstream project that is used in winetricks here: https://github.com/ProjectSynchro/powershell-wrapper-for-wine/tree/master/verbs

One potential issue with this is the fact that you need to call on another custom verb, which in my experience doesn't seem to always work. (winetricks has no idea the other custom verb exists). You could work around this by always calling on powershell_core and powershell, but ideally just calling powershell would be nice :)

  1. Cherrypick these winetricks commits:
    Winetricks/winetricks@07fa5dc
    Winetricks/winetricks@d486bc9
    Winetricks/winetricks@eeaed1f
    Winetricks/winetricks@72b934e

@GloriousEggroll GloriousEggroll marked this pull request as ready for review August 31, 2024 19:49
@GloriousEggroll GloriousEggroll merged commit 0c51dfa into Open-Wine-Components:master Aug 31, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants