-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Raw entity ids support #228
base: master
Are you sure you want to change the base?
Conversation
@tomershefi can you also add a test case that demonstrates how this works? I have a concern for the case where clients of this module expect the referential integrated to be maintained and in fact enforced. Does this PR bypass that? If so, can it be configured optionally? |
So far OBA has been my first line of defense against non-compliant GTFS feeds and it would be lovely if the referential integrity guarantees could be maintained. I would like to get an exception about this as early as possible. |
Hey, @sheldonabrown @leonardehrenfried |
Hey, @sheldonabrown @leonardehrenfried. |
I frankly would not be in favour of supporting invalid gtfs files. I suggest you use a clean up tool like gtfstidy before reading the feed. |
I'm not a maintainer though. @sheldonabrown is. |
@leonardehrenfried - @sheldonabrown what do you think? thanks |
6aa1af3
to
3f0f297
Compare
This upgrade supports GTFS files that contain entities that reference other entities which do not exist in the GTFS.
A good example maybe a stop_time entity that references a trip id that does not exist in trips.txt.
This is a very common problem because many providers supply such GTFS files.
Up until now we overcame this issue by using extensions but this is very inefficient especially in large GTFS files.
Thank you very much!