Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CommonHTML fixes for digits, Jeem, and Haa #16

Conversation

shadinaif
Copy link
Contributor

@shadinaif shadinaif commented Feb 17, 2019

In CommonHTML enviroment: this is to fix the render for some scripts related to numbers and letters with (tatweel جـ هـ):

Test case 1

fix position for \frac operator
\frac{1}{2}+\frac{A}{B}+\frac{C}{E}
before:
selection_006

after:
selection_007

Test case 2

fix over-line position for numbers
\overline{A}\space\overline{B}\space\overline{0}\space\overline{1}\space\overline{2}
before:
selection_008

after:
selection_009

Test case 3:

fix over-line position for Jeem and Haa
\overline{A}\overline{B}\overline{C}\overline{D}\overline{E}\overline{F}
before:
selection_020

after:
selection_011

Test case 4:

fix bar position for Jeem and Haa
\bar{A}\bar{B}\bar{C}\bar{D}\bar{E}\bar{F}
before:
selection_012

after:
selection_013

Test case 5:

fix numbers position inside square root. Applied on Jeem and Haa too
\sqrt{12345678c}
before:
selection_014

after:
selection_015

Test Case 6 has been removed because it is not valid in Arabic. Users must use \transn to represent decimals. That will convert the dot to the Arabic decimal comma separator
Example: \transn{1.234}\\\overline{\transn{1.234}}
selection_022

Test case 6:

fix text alignment for decimal numbers when used with \\
1.234\\\overline{1.234}
before:
selection_021

Fixes #10

@shadinaif
Copy link
Contributor Author

@OmarIthawi This PR is ready for your review :)

@OmarIthawi
Copy link
Owner

@shadinaif Please bump up the version (like we did in bc9ff76) to 2.1.0, to denote the major updates you've done.

I think all of the changes look good, but I need to double check on the Test Case 6 updates shortly.

Repository owner deleted a comment Feb 18, 2019
@shadinaif
Copy link
Contributor Author

Version bump is done @OmarIthawi .

Regarding Test Case 6, this is the fixing code 8704990#diff-0f0b9bfbcff9748d4ec0e7b8ebd1ebe0R43

@OmarIthawi
Copy link
Owner

OmarIthawi commented Feb 18, 2019

Version bump is done @OmarIthawi .

Regarding Test Case 6, this is the fixing code 8704990#diff-0f0b9bfbcff9748d4ec0e7b8ebd1ebe0R43

Thanks @shadinaif, I've copied it to a new issue (#17). Will take a look soon.

@shadinaif
Copy link
Contributor Author

@OmarIthawi Thank you for opening the new issue #17 . Indeed, the \transn should be retiring (carefully) 👍

I believe the PR is ready now for your final review

@OmarIthawi OmarIthawi self-requested a review February 21, 2019 09:44
Copy link
Owner

@OmarIthawi OmarIthawi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@OmarIthawi OmarIthawi merged commit 9bf2a65 into OmarIthawi:master Feb 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Too tall square root when numbers used
2 participants