♻️ Remove magic number from cursor offset in auto completer

OkunaOrg · Jun 19, 2020 · e66eeb6 · e66eeb6
1 parent f21fe05
commit e66eeb6
Showing 1 changed file with 7 additions and 8 deletions.
diff --git a/lib/services/text_autocompletion.dart b/lib/services/text_autocompletion.dart
@@ -78,14 +78,13 @@ class TextAutocompletionService {
       onPrefixMissing();
     }
 
-    var newText = text.substring(0, cursorPosition - lastWord.length) +
-        '$prefix$value ' +
-        text.substring(cursorPosition);
-    var newSelection = TextSelection.collapsed(
-        offset: cursorPosition - lastWord.length + prefix.length + value.length + 1);
-
-    textController.value =
-        TextEditingValue(text: newText, selection: newSelection);
+    var newTextStart =
+        text.substring(0, cursorPosition - lastWord.length) + '$prefix$value ';
+    var newTextEnd = text.substring(cursorPosition);
+    var newSelection = TextSelection.collapsed(offset: newTextStart.length);
+
+    textController.value = TextEditingValue(
+        text: newTextStart + newTextEnd, selection: newSelection);
   }
 }