Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[All Hosts] (manifest) reorg the manifest part of the TOC #4727

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

Rick-Kirkham
Copy link
Contributor

@Rick-Kirkham Rick-Kirkham commented Aug 12, 2024

Don't merge until preview of WXP in unified manifest because the include is used in custom function docs which won't be updated until then.

Copy link
Contributor

Learn Build status updates of commit 45b1263:

⚠️ Validation status: warnings

File Status Preview URL Details
docs/includes/manifest-guidance.md ⚠️Warning View Details
docs/toc.yml ✅Succeeded View

docs/includes/manifest-guidance.md

  • Line 7, Column 1: [Warning: code-block-indented - See documentation] Indented code blocks aren't allowed. Use a Markdown code block surrounded by triple backticks (```).

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

Copy link
Contributor

Learn Build status updates of commit 4cdad34:

⚠️ Validation status: warnings

File Status Preview URL Details
docs/includes/manifest-guidance.md ⚠️Warning View Details
docs/toc.yml ✅Succeeded View

docs/includes/manifest-guidance.md

  • Line 7, Column 1: [Warning: code-block-indented - See documentation] Indented code blocks aren't allowed. Use a Markdown code block surrounded by triple backticks (```).

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

Copy link
Contributor

Learn Build status updates of commit 3cf8d64:

✅ Validation status: passed

File Status Preview URL Details
docs/includes/manifest-guidance.md ✅Succeeded View
docs/toc.yml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

Learn Build status updates of commit 909aa05:

✅ Validation status: passed

File Status Preview URL Details
docs/includes/manifest-guidance.md ✅Succeeded View
docs/toc.yml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

@alison-mk alison-mk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with one suggestion

docs/includes/manifest-guidance.md Outdated Show resolved Hide resolved
Copy link
Contributor

Learn Build status updates of commit 2cb30b9:

✅ Validation status: passed

File Status Preview URL Details
docs/includes/manifest-guidance.md ✅Succeeded View
docs/toc.yml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

docs/toc.yml Outdated Show resolved Hide resolved
Copy link
Contributor

Learn Build status updates of commit 57d8d9b:

✅ Validation status: passed

File Status Preview URL Details
docs/includes/manifest-guidance.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

Learn Build status updates of commit 627e23f:

❌ Validation status: errors

Please follow instructions here which may help to resolve issue.

File Status Preview URL Details
❌Error Details

  • [Error: CannotMergeCommit] Cannot merge commit 627e23f45758b943bb3939624e6f689732ad7b29 in branch reorg-manifest of repository https://github.com/OfficeDev/office-js-docs-pr into branch main (commit 2bf4d62e44e9e24252207abe3d8ce7ff08dfc64d). Please follow this documentation: https://help.github.com/articles/resolving-a-merge-conflict-using-the-command-line/ to use git.exe to resolve you content conflicts locally and then push to remote.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

Copy link
Contributor

Learn Build status updates of commit 0572508:

✅ Validation status: passed

File Status Preview URL Details
docs/develop/json-manifest-overview.md ✅Succeeded View
docs/develop/unified-manifest-overview.md ✅Succeeded View
docs/includes/manifest-guidance.md ✅Succeeded View
docs/includes/unified-manifest-support-note.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants