feat:add verification of usdc contracts #99
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TucksonDev
commented
Dec 20, 2024
| @@ -35,6 +35,15 @@ const config = { | |||
| }, | |||
| }, | |||
| }, | |||
| { | |||
| version: '0.6.12', | |||
There was a problem hiding this comment.
Needed to verify IFiatTokenProxy
TucksonDev
commented
Dec 20, 2024
| @@ -30,6 +30,8 @@ | |||
| "test:creation-code": "hardhat test test-e2e/creationCodeTest.ts", | |||
| "blockscout:verify": "hardhat run ./scripts/orbitVerifyOnBlockscout.ts", | |||
| "deploy:usdc-token-bridge": "hardhat run scripts/usdc-bridge-deployment/deployUsdcBridge.ts", | |||
| "verify:usdc-token-bridge": "hardhat run scripts/usdc-bridge-deployment/verifyUsdcBridge.ts", | |||
| "verify:l1-usdc-token-bridge": "hardhat run scripts/usdc-bridge-deployment/verifyParentUsdcBridge.ts", | |||
There was a problem hiding this comment.
Added to verify the contracts on the parent chain although they are likely to be already verified by bytecode match
TucksonDev
commented
Dec 20, 2024
| (await l1UsdcGateway.l2USDC()).toLowerCase() != l2Usdc.toLowerCase() || | ||
| (await l1UsdcGateway.owner()).toLowerCase() != _owner.toLowerCase() || | ||
| (await l1UsdcGateway.counterpartGateway()).toLowerCase() != | ||
| _l2CounterPart.toLowerCase() |
There was a problem hiding this comment.
In some cases, these addresses don't match because of casing issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds 2 scripts to verify the bridged usdc contracts: