-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bridged usdc custom gateway #87
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gzeoneth
reviewed
Jul 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, some comments
also new contracts can be added into storage test
* Deployer script draft * Deploy bridged usdc * Init gateways * Add env.example * Add register gateway script draft * Load upg executor * Add registration logic * Add env examples * Do registration in the same script * Remove separate script for registration * Add env var check * Get rollup address from inbox * Init logic to dummy values * Use SDK estimations instead of hard-coding retryable params * If owner is multisig print TX data to a file * Make gw registration work for fee token chains * Deploy orbit gateway when fee token used * Make ROLLUP_OWNER_KEY optional * Set minter role to L2 gateway * Refactor * Check initialization * Add yarn action * Add readme for deployment * Deploy master minter * Use MasterMinter contract * Update readme with usdc upgrade procedure * Add comment * Add fee transfer logic to list of TXs stored into a file * Do scaling in case of non-18 decimals fee token * Add more docs * Update slither db * Readme clarifications
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Custom USDC gateway (for parent and child chain), complying with Bridged USDC Standard. These contracts can be used by new Orbit chains which want to provide USDC bridging solution and keep the possibility to upgrade to native USDC at some point later. This solution will NOT be used in existing Arbitrum chains.
Reference to the Circle's Bridged USDC: https://github.com/circlefin/stablecoin-evm/blob/master/doc/bridged_USDC_standard.md
Expected flow of actions on a fresh Orbit chain could look like this:
setBurner(address)
functionsetBurnAmount(uint256)
on the parent child gateway where the amount matches the total supplysetUsdcOwnershipTransferrer(address)
to set the account (provided and controlled by Circle) which will be able to transfer the bridged USDC ownership and proxy adminusdcOwnershipTransferrer
account to triggertransferUSDCRoles(address)
which will set caller as USDC proxy admin and will transfer USDC ownership to the provided address (according to standard [requirements](https://github.com/circlefin/stablecoin-evm/blob/master/doc/bridged_USDC_standard.md#token-roles))burnLockedUSDC()
on the L1 USDC gateway usingburner
account to burn theburnAmount
of USDCPR containts USDC gateway implementation for parent chain and child chain, Foundry unit tests and Hardhat e2e test.