This repository has been archived by the owner on Nov 26, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 27
Initial implementation of wasmbinary to wat #207
Open
joshuacolvin0
wants to merge
10
commits into
stylus
Choose a base branch
from
wasm2wat
base: stylus
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshuacolvin0
commented
Mar 11, 2024
arbitrator/prover/src/print.rs
Outdated
for (i, type_idx) in self.functions.iter().enumerate() { | ||
let i1 = i as u32; | ||
|
||
let export_str = match self.maybe_func_name(i1 + 1) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Concerned that incorrect index is being used here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed :)
joshuacolvin0
changed the title
Initial implementation of wasmbinary to wat
STY-22: Initial implementation of wasmbinary to wat
Mar 11, 2024
rachel-bousfield
changed the title
STY-22: Initial implementation of wasmbinary to wat
Initial implementation of wasmbinary to wat
Mar 12, 2024
rachel-bousfield
suggested changes
Mar 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made some simplifications & fixes. There's just two things to note
- The reason function names are sometimes wrong is that we're not considering imports. If a WASM has no imports, then the names are correct. However if there's
n
imports, the names will be shiftedn
away. Fixing this requires changingfunc_name
,maybe_func_name
, etc to distinguish imports from local functions. - Some of the changes affect
Module
printing, which may be worth checking again and fixing where visually affected
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial implementation. The wasm instructions are currently not formatted in wat format, so everything is provided, but result is not valid wat.
Resolves STY-22