This repository has been archived by the owner on Nov 26, 2024. It is now read-only.
New Module Hash Model #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshuacolvin0
approved these changes
Oct 14, 2023
| @@ -35,60 +35,47 @@ extern "C" { | |||
| #[repr(C, align(256))] | |||
| struct MemoryLeaf([u8; 32]); | |||
|
|
|||
| /// Compiles and instruments a user wasm. | |||
| /// Instruments a user wasm. | |||
There was a problem hiding this comment.
Instruments and activates?
| sp: usize, | ||
| ) { | ||
| let mut sp = GoStack::new(sp); | ||
| let wasm = sp.read_go_slice_owned(); | ||
| let page_limit = sp.read_u16(); | ||
| let version = sp.read_u16(); | ||
| let debug = sp.read_bool32(); | ||
| let (out_hash_ptr, out_hash_len) = sp.read_go_slice(); | ||
| let module_hash = sp.read_go_ptr(); | ||
| let gas = sp.read_go_ptr(); |
There was a problem hiding this comment.
maybe add comment about modules_hash being output, gas being input & output
arbos/programs/programs.go
Outdated
| @@ -342,7 +337,7 @@ func (p Programs) setProgram(codehash common.Hash, program Program) error { | |||
| if err != nil { | |||
| return err | |||
| } | |||
| return p.compiledHashes.Set(codehash, program.compiledHash) | |||
| return p.compiledHashes.Set(codehash, program.moduleHash) | |||
There was a problem hiding this comment.
update p.compiledHashes to p.moduleHashes?
PlasmaPower
reviewed
Oct 16, 2023
arbos/programs/native.go
Outdated
| @@ -93,6 +93,7 @@ func activateProgram( | |||
| func callProgram( | |||
| address common.Address, | |||
| program Program, | |||
There was a problem hiding this comment.
This program parameter is no longer used now that moduleHash is passed in separately.
arbos/burn/burn.go
Outdated
| @@ -13,7 +13,7 @@ import ( | |||
| type Burner interface { | |||
| Burn(amount uint64) error | |||
| Burned() uint64 | |||
| GasLeft() *uint64 | |||
| GasLeft() *uint64 // SystemBurner's panic | |||
There was a problem hiding this comment.
The apostrophe doesn't read well to me, could you do
// `SystemBurner`s panic
instead?
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR leverages the new onchain module hash to make a number of simplifications and improvements
This PR includes conceptual changes that will be easier to track by adopting the following nomenclature.
Associated PRs