Implement transient get/set bytes32 hostios #92
+47
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix Address has_code check
Set Sepolia Priv Key as CI Env Var
rauljordan
approved these changes
Dec 8, 2023
rachel-bousfield
suggested changes
Dec 14, 2023
stylus-sdk/src/hostio.rs
Outdated
| /// value stored in the EVM transient storage at offset `key`, which will be `0` when not | ||
| /// previously set. The semantics, then, are equivalent to that of the EVM's [`TLOAD`] opcode. | ||
| /// | ||
| /// [`TLOAD`]: https://www.evm.codes/#5c |
There was a problem hiding this comment.
Let's link the following for now since these opcodes don't yet exist
https://eips.ethereum.org/EIPS/eip-1153
stylus-sdk/src/hostio.rs
Outdated
| /// | ||
| /// [`TSTORE`]: https://www.evm.codes/#5d | ||
| #[allow(dead_code)] | ||
| pub fn storage_transient_store_bytes32(key: *const u8, value: *const u8); |
There was a problem hiding this comment.
As we discussed on slack, let's rename these
stylus-sdk/src/storage/mod.rs
Outdated
| /// | ||
| /// # Safety | ||
| /// | ||
| /// May alias storage. |
There was a problem hiding this comment.
I'd say May alias transient storage.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.