Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: correct encoding in sol interface #177

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

fix: correct encoding in sol interface #177

wants to merge 5 commits into from

Conversation

qalisander
Copy link

@qalisander qalisander commented Dec 6, 2024 •
edited
Loading

Description

  • Use abi_encode_params instead of abi_encode inside sol interface macro.
  • Update alloy libs 0.8.13 -> 0.8.14.
  • Remove not used stylus_sdk::abi::export.

Checklist

  • I have documented these changes where necessary.
  • I have read the DCO and ensured that these changes comply.
  • I assign this work under its open source licensing.

rauljordan
rauljordan previously approved these changes Dec 6, 2024
View reviewed changes
@rauljordan
Copy link
Contributor

hi @qalisander thanks for the PR! Looks like there are some conflicts and then we'll be good to merge

@qalisander qalisander force-pushed the fix-encoding-in-sol-interface branch from 2af4d8e to 5b68e1f Compare December 11, 2024 16:26
@qalisander
Copy link
Author

I see, that all pipelines can pass.
@rauljordan do you think we're good to merge it?

@rory-ocl rory-ocl self-requested a review December 19, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rory-ocl rory-ocl rory-ocl approved these changes

@rauljordan rauljordan Awaiting requested review from rauljordan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@qalisander @rauljordan @rory-ocl