Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: possibility to reuse errors under SolidityError macro #136

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

qalisander
Copy link

Description

Adds implementation of stylus_sdk::call::MethodError trait inside SolidityError macro.

Resolves #135

Checklist

  • I have documented these changes where necessary.
  • I have read the DCO and ensured that these changes comply.
  • I assign this work under its open source licensing.

@qalisander
Copy link
Author

qalisander commented Aug 20, 2024

@rory-ocl does this feature seems rational to you? we're currently implementing them by ourselves.

@0xNeshi
Copy link

0xNeshi commented Dec 9, 2024

This would mean that pub enum Error that contains these Solidity errors (defined inside sol!) would have to inherit SolError as well, otherwise there may be problems with exporting ABI (see OpenZeppelin/rust-contracts-stylus#439 (comment)).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature: add possibility to reuse error for the other contract
2 participants