Add transient hostios #15
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rachel-bousfield
suggested changes
Dec 14, 2023
include/hostio.h
Outdated
| @@ -36,7 +36,7 @@ VM_HOOK(account_codehash) void account_codehash(const uint8_t * address, uint8_t | |||
| * that of the EVM. This means that, under the hood, this hostio is accessing the 32-byte | |||
| * value stored in the EVM state trie at offset `key`, which will be `0` when not previously | |||
| * set. The semantics, then, are equivalent to that of the EVM's [`SLOAD`] opcode. | |||
| * | |||
There was a problem hiding this comment.
Let's re-add these, since they're the way the blocks are currently formatted
| * | ||
| * [`TLOAD`]: https://www.evm.codes/#5c | ||
| */ | ||
| VM_HOOK(transient_load_bytes32) void transient_load_bytes32(const uint8_t * key, uint8_t * dest); |
There was a problem hiding this comment.
As we discussed on slack, let's rename these.
include/hostio.h
Outdated
| * the EVM transient storage at offset `key`. Furthermore, refunds are tabulated exactly as in the | ||
| * EVM. The semantics, then, are equivalent to that of the EVM's [`TSTORE`] opcode. | ||
| * | ||
| * [`TSTORE`]: https://www.evm.codes/#5d |
There was a problem hiding this comment.
Let's link the following for now since these opcodes don't yet exist
https://eips.ethereum.org/EIPS/eip-1153
include/storage.h
Outdated
Comment on lines
45
to
65
| /** | ||
| * transient_load / store load or store a value from transient storage accordingly. | ||
| * | ||
| * The value of the first "storage" pointer is not used. | ||
| * generated headers provide: | ||
| * a const storage pointer when working for a view-only function | ||
| * a non const pointer for a mutating function | ||
| * no pointer (so don't call transient_load) for a pure function | ||
| * | ||
| */ | ||
| inline void transient_load(const void* storage, const uint8_t *key, uint8_t *dest) { | ||
| transient_load_bytes32(key, dest); | ||
| } | ||
|
|
||
| /** | ||
| * see documentation for transient_load | ||
| */ | ||
| inline void transient_store(void *storage, const uint8_t *key, const uint8_t *value) { | ||
| transient_store_bytes32(key, value); | ||
| } | ||
|
|
There was a problem hiding this comment.
Let's drop these for now, since we're not yet supporting higher-order affordances
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.