Add string varibles #55
Open
+18
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
TucksonDev
approved these changes
Jan 10, 2025
| @@ -45,9 +50,11 @@ impl Contract { | |||
| // Here are some global variables | |||
| let _timestamp = block::timestamp(); | |||
| let _amount = msg::value(); | |||
| let _base_uri = self.base_uri.get_string(); | |||
There was a problem hiding this comment.
I don't think we need to add this here. This section is for global variables. We are already showing examples for state variables in the previous function.
There was a problem hiding this comment.
I put here is because we don't mention how to get value from string type state, maybe we add another read-only function for this and also put how to get owner and max_supply there?
There was a problem hiding this comment.
Either that, or have a specific "section" for reading those (something under a different comment, since that one suggests those are "global variables")
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Value set to string is different from other types, we need to mention it.