Fall back to the confirmed state if the agreed state is nil. #2854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way, the block validators will get updates even for non-staked nodes. Fixes NIT-3009
cla-bot
bot
added
the
s
amsanghi
previously approved these changes
Dec 26, 2024
tsahee
previously approved these changes
Dec 26, 2024
staker/bold/bold_staker.go
Outdated
| @@ -260,6 +260,13 @@ func (b *BOLDStaker) Start(ctxIn context.Context) { | |||
| } | |||
|
|
|||
| if confirmedGlobalState != nil { | |||
| if agreedGlobalState == nil { | |||
There was a problem hiding this comment.
I can live with that.. but seems better to read confirmedState before agreedState, and to set agreedGlobalState = confirmedGlobalState if it's nil. That way theres's no need to duplicate logic, and it makes sense (that any node sees confirmed as something it agreed to)
This way, the behavior of falling back to the confirmed state is more readable.
tsahee
approved these changes
Dec 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way, the block validators will get updates even for non-staked nodes.
Fixes NIT-3009