Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deduplicate arbitrator RustBytes types #2830

Merged
merged 5 commits into from
Dec 13, 2024
Merged

Deduplicate arbitrator RustBytes types #2830

merged 5 commits into from
Dec 13, 2024

Conversation

PlasmaPower
Copy link
Collaborator

Previously, we had one for Stylus and another for the arbitrator prover library, despite them doing basically the same thing. This deduplicates them to use the same type.

@PlasmaPower PlasmaPower added the arbitrator Relates to the Arbitrator proving component label Dec 12, 2024
@PlasmaPower PlasmaPower requested a review from tsahee December 12, 2024 03:16
@cla-bot cla-bot bot added the s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA. label Dec 12, 2024
tsahee
tsahee previously approved these changes Dec 12, 2024
Copy link
Contributor

@tsahee tsahee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

eljobe
eljobe previously approved these changes Dec 12, 2024
Copy link
Member

@eljobe eljobe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PlasmaPower PlasmaPower dismissed stale reviews from eljobe and tsahee via e2c4dc2 December 12, 2024 16:09
@PlasmaPower PlasmaPower requested a review from tsahee December 12, 2024 20:23
@PlasmaPower PlasmaPower merged commit 63fac1c into master Dec 13, 2024
18 checks passed
@PlasmaPower PlasmaPower deleted the rust-bytes-dedup branch December 13, 2024 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arbitrator Relates to the Arbitrator proving component design-approved s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants