Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[config change] pebble: no-sync mode and increasing level sizes #2800

Merged
merged 8 commits into from
Dec 20, 2024
Merged

[config change] pebble: no-sync mode and increasing level sizes #2800

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
c174c1f
add SyncMode pebble config, default to NO-SYNC mode and increasing le…
magicxyyz Nov 19, 2024
077f55b
update geth pin
magicxyyz Nov 19, 2024
206ffb7
Merge branch 'master' into pebble-no-sync-and-levels
magicxyyz Nov 19, 2024
b730c3f
add missing sync-mode flag in PebbleConfigAddOptions
magicxyyz Nov 19, 2024
ef338cd
Merge branch 'master' into pebble-no-sync-and-levels
magicxyyz Nov 25, 2024
58e3791
Merge master into pebble-no-sync-and-levels
joshuacolvin0 Dec 19, 2024
275dc27
Update geth pin
joshuacolvin0 Dec 19, 2024
b528421
Merge branch 'master' into pebble-no-sync-and-levels
joshuacolvin0 Dec 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion cmd/conf/database.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,16 +112,19 @@ func (c *PersistentConfig) Validate() error {
}

type PebbleConfig struct {
SyncMode bool `koanf:"sync-mode"`
MaxConcurrentCompactions int `koanf:"max-concurrent-compactions"`
Experimental PebbleExperimentalConfig `koanf:"experimental"`
}

var PebbleConfigDefault = PebbleConfig{
SyncMode: false, // use NO-SYNC mode, see: https://github.com/ethereum/go-ethereum/issues/29819
MaxConcurrentCompactions: runtime.NumCPU(),
Experimental: PebbleExperimentalConfigDefault,
}

func PebbleConfigAddOptions(prefix string, f *flag.FlagSet, defaultConfig *PebbleConfig) {
f.Bool(prefix+".sync-mode", defaultConfig.SyncMode, "if true sync mode is used (data needs to be written to WAL before the write is marked as completed)")
f.Int(prefix+".max-concurrent-compactions", defaultConfig.MaxConcurrentCompactions, "maximum number of concurrent compactions")
PebbleExperimentalConfigAddOptions(prefix+".experimental", f, &defaultConfig.Experimental)
}
Expand Down Expand Up @@ -180,7 +183,7 @@ var PebbleExperimentalConfigDefault = PebbleExperimentalConfig{
BlockSize: 4 << 10, // 4 KB
IndexBlockSize: 4 << 10, // 4 KB
TargetFileSize: 2 << 20, // 2 MB
TargetFileSizeEqualLevels: true,
TargetFileSizeEqualLevels: false,

L0CompactionConcurrency: 10,
CompactionDebtConcurrency: 1 << 30, // 1GB
Expand Down Expand Up @@ -251,6 +254,7 @@ func (c *PebbleConfig) ExtraOptions(namespace string) *pebble.ExtraOptions {
walDir = path.Join(walDir, namespace)
}
return &pebble.ExtraOptions{
SyncMode: c.SyncMode,
BytesPerSync: c.Experimental.BytesPerSync,
L0CompactionFileThreshold: c.Experimental.L0CompactionFileThreshold,
L0CompactionThreshold: c.Experimental.L0CompactionThreshold,
Expand Down
2 changes: 1 addition & 1 deletion go-ethereum
Open in desktop
Submodule go-ethereum updated 2 files
+1 −0 ethdb/pebble/extraoptions.go
+1 −1 ethdb/pebble/pebble.go
Loading