Fix timeboost auction resolution queue handling

[Tristan-Wilson]

If there were auction resolution transactions in the timeboostAuctionResolutionTxQueue but no normal transactions came through the txQueue, then the auction resolution tx would not be processed because the main createBlock loop was waiting on the txQueue channel and not the auction resolution queue. We had tried to use the same pattern as we had used for the txRetryQueue but this is not correct as the auction resolution queue, like the txQueue, can have items added to it asynchronously, whereas the txRetryQueue is only added to from the createBlock itself.

This commit makes the timeboostAuctionResolutionTxQueue also a channel so that it can be waited on in the same select statement and handle asynchronous events correctly.

This also fixes two issues related to shutdown. The first was a race condition with shutting down and txRetryQueue handling, and the second was that we were missing adding forwarding for outstanding auction resolution txs upon shutdown.

Fixes NIT-2878

Testing done

Express lane system test passes

go test -v -count=1 -run TestSequencerFeed_ExpressLaneAuction_ExpressLaneTxsHaveAdvantage ./system_tests

Confirmed fix by re-running manual repro test with nitro-testnode.

Followed instructions in OffchainLabs/nitro-testnode#95 to start nitro testnode in timeboost mode and made a bid. As soon as the auction was resolved it was picked up immediately by the sequencer.

timeboost-bid-validator-1  | INFO [10-30|18:20:11.773] Validated bid                            bidder=
0xC3c76AaAA7C483c5099aeC225bA5E4269373F16b amount=0x3b9aca00 round=0xc elapsed="645.456µs"             
timeboost-auctioneer-1     | INFO [10-30|18:20:11.905] Consumed validated bid                   bidder=
0xC3c76AaAA7C483c5099aeC225bA5E4269373F16b amount=0x3b9aca00 round=0xc                                 
timeboost-auctioneer-1     | INFO [10-30|18:20:45.000] New auction closing time reached         closing
Time=2024-10-30T18:20:45+0000 totalBids=1                                                              
timeboost-auctioneer-1     | INFO [10-30|18:20:47.004] Resolving auction with single bid        round=1
2              
sequencer-1                | INFO [10-30|18:20:47.004] Prioritizing auction resolution transaction from
 auctioneer txHash=0x505037fc7347e76861209cd7f1cc2b01efe5b31a55af2ed6e71935f882d93e27                  
sequencer-1                | INFO [10-30|18:20:47.004] Popped the auction resolution tx         txHash=
505037..d93e27                                                                                         
sequencer-1                | INFO [10-30|18:20:47.248] New express lane controller assigned     round=1
2 controller=0xC3c76AaAA7C483c5099aeC225bA5E4269373F16b                                                
sequencer-1                | WARN [10-30|18:20:47.250] New express lane controller did not match previo
us controller round=12 previous=0x0000000000000000000000000000000000000000 new=0xC3c76AaAA7C483c5099aeC
225bA5E4269373F16b    

[ganeshvanahalli]

Nice :)
LGTM (with a minor suggestion)

[ganeshvanahalli]

Is it worth it to change this to something like SynchronizedQueue[T any] and add it to containers package? Seems like it can be used in other places as well