Validator recording fix #2660
Validator recording fix #2660
Conversation
cla-bot
bot
added
the
s
| type BlockRecorderConfig struct { | ||
| TrieDirtyCache int `koanf:"trie-dirty-cache"` | ||
| TrieCleanCache int `koanf:"trie-clean-cache"` | ||
| MaxPrepared int `koanf:"max-prepared"` |
There was a problem hiding this comment.
I think we should have this extend arbitrum.RecordingDatabaseConfig (having that as an unnamed field, I forget the proper terminology in geth). Then we can call arbitrum.RecordingDatabaseConfigAddOptions inside BlockRecorderConfigAddOptions. Alternatively, I'd just drop the geth struct, or at least drop its koanf options and the AddOptions function to clarify that it's not directly part of the config.
There was a problem hiding this comment.
I think I'll remove the geth koanf and AddOptions
staker/stateless_block_validator.go
Outdated
| return true, &fullInfo, nil | ||
| } | ||
|
|
||
| func clonePreimagesInto(dest, source map[arbutil.PreimageType]map[common.Hash][]byte) { |
There was a problem hiding this comment.
nit: I'd call this copyPreimagesInto, to clarify that it won't clear out the destination and only adds new entries
staker/stateless_block_validator.go
Outdated
| func clonePreimagesInto(dest, source map[arbutil.PreimageType]map[common.Hash][]byte) { | ||
| for piType, piMap := range source { | ||
| if dest[piType] == nil { | ||
| dest[piType] = make(map[common.Hash][]byte, len(source[piType])) |
There was a problem hiding this comment.
nit: len(source[piType]) -> len(piMap)
staker/stateless_block_validator.go
Outdated
| return nil, err | ||
| } | ||
| msg.Message.BatchGasCost = nil | ||
| if err := msg.Message.FillInBatchGasCost(valBatchFetcher); err != nil { |
There was a problem hiding this comment.
technically, we don't need the preimages list for the batch gas cost calculation, but I don't think there's much overhead in practice especially with the cache so it's probably fine
There was a problem hiding this comment.
That's a good point and I do want to solve it because it allows making some things actually simpler..
PTAL
staker/stateless_block_validator.go
Outdated
| if recording.Preimages != nil { | ||
| e.Preimages[arbutil.Keccak256PreimageType] = recording.Preimages | ||
| recordingPreimages := make(map[arbutil.PreimageType]map[common.Hash][]byte) | ||
| recordingPreimages[arbutil.Keccak256PreimageType] = recording.Preimages |
There was a problem hiding this comment.
nit: map initialization syntax simplifies this slightly:
recordingPreimages := map[arbutil.PreimageType]map[common.Hash][]byte {
arbutil.Keccak256PreimageType: recording.Preimages,
}
…dator_fetch_batch_fix
Fixes batch recording.
Mostly:
pulls-in: OffchainLabs/go-ethereum#358 (though not necessary, it just removes now-unused code from geth)