Fix reorg on init flags #2538
Fix reorg on init flags #2538
Conversation
cla-bot
bot
added
the
s
PlasmaPower
changed the title
PlasmaPower
changed the title
| f.Uint64(prefix+".recreate-missing-state-from", InitConfigDefault.RecreateMissingStateFrom, "block number to start recreating missing states from (0 = disabled)") | ||
| f.Bool(prefix+".rebuild-local-wasm", InitConfigDefault.RebuildLocalWasm, "rebuild local wasm database on boot if needed (otherwise-will be done lazily)") | ||
| f.Int64(prefix+".reorg-to-batch", InitConfigDefault.ReorgToBatch, "rolls back the blockchain to a specified batch number") | ||
| f.Int64(prefix+".reorg-to-message-batch", InitConfigDefault.ReorgToMessageBatch, "rolls back the blockchain to the first batch at or before a given message index") | ||
| f.Int64(prefix+".reorg-to-block-batch", InitConfigDefault.ReorgToBlockBatch, "rolls back the blockchain to the first batch at or before a given block number") |
There was a problem hiding this comment.
add to Validate() a test that at most one of those is >= 0
execution/interface.go
Outdated
| @@ -70,6 +70,7 @@ type FullExecutionClient interface { | |||
| Maintenance() error | |||
|
|
|||
| ArbOSVersionForMessageNumber(messageNum arbutil.MessageIndex) (uint64, error) | |||
| BlockNumberToMessageIndex(blockNum uint64) (arbutil.MessageIndex, error) | |||
There was a problem hiding this comment.
I don't think that reorg is a good enough reason to add it to the API.
reorg-to-*batch will always be an advanced functionality, that should only be used by those who know what they are doing. I don't mind making it a little harder.
We should make genesis-block-number be easy to find. It's in chain-config which sounds reasonable.. maybe we should print chain config on init so it'll be even easier to find?
There was a problem hiding this comment.
Most 3rd party providers only really know block numbers. Is there a significant downside to adding this interface? It seems generally useful to me
There was a problem hiding this comment.
Looking at this a bit more, we have access to the chain config directly here, so I switched to using that instead and removed this interface
arbnode/transaction_streamer.go
Outdated
|
|
||
| // If not started, use a background context. | ||
| // This can happening when reorging on startup using the init flag. | ||
| ctx := context.Background() |
There was a problem hiding this comment.
this should no longer be necessary, since now reorg happends after Start
This is a successor to #2036 which only reorgs to batch boundaries, as suggested there.
NIT-2710