Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check all "not found" errors #2532

Merged
merged 4 commits into from
Jul 30, 2024
Merged

Check all "not found" errors #2532

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
14c6386
Check all "not found" errors
sveitser Jul 30, 2024
c227bab
Use dbutil.IsErrNotFound
sveitser Jul 30, 2024
ac0da42
Merge branch 'master' into cherry-pick/fix-pebble-not-found-error
sveitser Jul 30, 2024
bef86a3
Merge branch 'master' into cherry-pick/fix-pebble-not-found-error
sveitser Jul 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion arbnode/dataposter/dbstorage/storage.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ func (s *Storage) Get(_ context.Context, index uint64) (*storage.QueuedTransacti
key := idxToKey(index)
value, err := s.db.Get(key)
if err != nil {
if errors.Is(err, leveldb.ErrNotFound) {
if isErrNotFound(err) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think there's an isErrNotFound in scope here. Are you sure you didn't mean dbutil.IsErrNotFound ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, you're right. The code has been moved recently. I cherry picked from our fork where the function is still in this file.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

c227bab

return nil, nil
}
return nil, err
Expand Down