Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RPC Change] Move validateMessageNumber method to arbdebug ns #2514

Merged
merged 1 commit into from
Jul 23, 2024
+1 −1
Merged

[RPC Change] Move validateMessageNumber method to arbdebug ns #2514

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion arbnode/node.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -779,7 +779,7 @@ func CreateNode(
}
if currentNode.StatelessBlockValidator != nil {
apis = append(apis, rpc.API{
Namespace: "arbvalidator",
Namespace: "arbdebug",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to worry about existing clients of the API which might still be expecting it in the previous namespace?
(i.e. Should we expose the same method in both the old and new namespace for a transition period?)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Totally see your point. From my understanding of the issue, I think we're breaking them deliberately since it wasn't supposed to be exposed in that namespace originally.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're deliberately moving it to stress the point that this is a debug functionality and not the way to validate blocks (because you must validate all blocks up to X to validate X).
If anyone is using this interface today they are probably wrong, and should use block_validator instead.

Version: "1.0",
Service: &BlockValidatorDebugAPI{
val: currentNode.StatelessBlockValidator,
Expand Down
Loading