Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This averts a bug where gotesum seems to succeed if there were failures in multiple packages, some packages were o.k. after rerunning failures and some were not.
not sure if this is the best way - but it seems to work.
Here is an example of the problem: see how Go Test(default) step passes CI, and it's "run tests without race detection" step appears as passing even though it did record errors:
https://github.com/OffchainLabs/nitro/actions/runs/10015286108/job/27686456877
Here is execution for the same ci with said fix - notice that both (defaults) and (race) fail - correctly, when executed 3 times:
https://github.com/OffchainLabs/nitro/actions/runs/10014238547?pr=2504