Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use default rpcclient config when unmarshalling JSON #2508

Merged
merged 1 commit into from
Jul 19, 2024

Conversation

PlasmaPower
Copy link
Collaborator

Fixes NIT-2691

JSON unmarshalling an array of ClientConfigs is used in stateless_block_validator.go. With this PR, it'll now respect the default rpcclient config options, such as the max log line length.

@PlasmaPower PlasmaPower requested a review from tsahee July 19, 2024 14:56
@cla-bot cla-bot bot added the s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA. label Jul 19, 2024
Copy link
Member

@joshuacolvin0 joshuacolvin0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PlasmaPower PlasmaPower enabled auto-merge July 19, 2024 15:09
@PlasmaPower PlasmaPower merged commit 656898d into master Jul 19, 2024
15 checks passed
@PlasmaPower PlasmaPower deleted the default-rpc-client-config branch July 19, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design-approved s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants