Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix disabling P2P #2485

Merged
merged 1 commit into from
Jul 12, 2024
Merged

Fix disabling P2P #2485

merged 1 commit into from
Jul 12, 2024

Conversation

PlasmaPower
Copy link
Collaborator

When removing the P2P options in #2462 I assumed it'd not listen to P2P, but I didn't realize the default was to listen on port 30303. This PR restores the code to disable P2P from before #2124

@cla-bot cla-bot bot added the s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA. label Jul 12, 2024
Copy link
Member

@joshuacolvin0 joshuacolvin0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joshuacolvin0 joshuacolvin0 enabled auto-merge July 12, 2024 21:31
@joshuacolvin0 joshuacolvin0 merged commit 7d1d84c into master Jul 12, 2024
15 checks passed
@joshuacolvin0 joshuacolvin0 deleted the fix-disable-p2p branch July 12, 2024 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design-approved s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants