Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NIT-1339] Test EstimateRetryableTicket With No Funds And Zero GasPrice #2482

Merged
merged 5 commits into from
Jul 16, 2024

Conversation

amsanghi
Copy link
Contributor

No description provided.

@cla-bot cla-bot bot added the s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA. label Jul 11, 2024
@amsanghi amsanghi marked this pull request as ready for review July 11, 2024 16:12
@gligneul
Copy link
Contributor

The test looks correct. However, the Linear ticket gave me the impression that we should fix this behavior instead of confirming it.

@amsanghi
Copy link
Contributor Author

The test looks correct. However, the Linear ticket gave me the impression that we should fix this behavior instead of confirming it.

Yeah the ticket was originally for fixing this behavior, but turns out the issue is already fixed (confirmed in the standup), so just adding a test for it.

@joshuacolvin0 joshuacolvin0 enabled auto-merge July 16, 2024 03:17
@joshuacolvin0 joshuacolvin0 merged commit a164d9a into master Jul 16, 2024
14 checks passed
@joshuacolvin0 joshuacolvin0 deleted the EstimateRetryableTicket_test branch July 16, 2024 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design-approved s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants