Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uppercase AS keyword in Dockerfile #2466

Merged
merged 1 commit into from
Jul 10, 2024
Merged

Uppercase AS keyword in Dockerfile #2466

merged 1 commit into from
Jul 10, 2024

Conversation

PlasmaPower
Copy link
Collaborator

Before this PR, on new Docker versions, we get a lot of warnings building like this:

 => WARN: FromAsCasing: 'as' and 'FROM' keywords' casing do not match (line 1)
 => WARN: FromAsCasing: 'as' and 'FROM' keywords' casing do not match (line 13)
 => WARN: FromAsCasing: 'as' and 'FROM' keywords' casing do not match (line 16)

This PR fixes these warnings by uppercasing the AS field whenever it appears in the Dockerfile.

@cla-bot cla-bot bot added the s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA. label Jul 10, 2024
joshuacolvin0
joshuacolvin0 approved these changes Jul 10, 2024
View reviewed changes
Copy link
Member

@joshuacolvin0 joshuacolvin0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PlasmaPower PlasmaPower merged commit 703ecdf into master Jul 10, 2024
11 of 13 checks passed
@PlasmaPower PlasmaPower deleted the docker-from-as-casing branch July 10, 2024 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshuacolvin0 joshuacolvin0 joshuacolvin0 approved these changes

Assignees
No one assigned
Labels
design-approved s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PlasmaPower @joshuacolvin0