[NIT-2626] Ignores P2P arguments provided through CLI arguments #2456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
s
PlasmaPower
requested changes
Jul 8, 2024
|
Closed as duplicate of #2462 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
P2P CLI arguments were introduced as a preparation for snap sync, which is not live yet.
However, as verified in #2419, some P2P values break Nitro when importing a database.
As a temporary mitigation, while those arguments are not useful for Nitro, and we don't figure out why they are causing issues, this PR makes Nitro to ignore P2P arguments provided through CLI arguments.